Improve handling of Adobe's CC Cleaner tool

This PR implements a try-catch-finally struct to do a better handling of Adobe's Creative Cloud Cleaner tool downloading and running of such program.

This will allow to see any errors that occurs if the URL changes, the tool fails to run, or anything else.

I also have moved the cleaning up process to the finally part of the structure, as it makes the most sense.

This tries to fix or sanitize the issue #1563.
This commit is contained in:
Ken Hoo
2024-02-20 18:37:06 +00:00
committed by GitHub
parent 31c6622926
commit fb49fb9efa

View File

@ -11,6 +11,7 @@ function Invoke-WPFRunAdobeCCCleanerTool {
Write-Host "The Adobe Creative Cloud Cleaner tool is hosted at" Write-Host "The Adobe Creative Cloud Cleaner tool is hosted at"
Write-Host "$url" Write-Host "$url"
try {
# Don't show the progress because it will slow down the download speed # Don't show the progress because it will slow down the download speed
$ProgressPreference='SilentlyContinue' $ProgressPreference='SilentlyContinue'
@ -20,9 +21,12 @@ function Invoke-WPFRunAdobeCCCleanerTool {
$ProgressPreference='Continue' $ProgressPreference='Continue'
Start-Process -FilePath "$env:TEMP\AdobeCreativeCloudCleanerTool.exe" -Wait -ErrorAction SilentlyContinue -Verbose Start-Process -FilePath "$env:TEMP\AdobeCreativeCloudCleanerTool.exe" -Wait -ErrorAction SilentlyContinue -Verbose
} catch {
Write-Error $_.Exception.Message
} finally {
if (Test-Path -Path "$env:TEMP\AdobeCreativeCloudCleanerTool.exe") { if (Test-Path -Path "$env:TEMP\AdobeCreativeCloudCleanerTool.exe") {
Write-Host "Cleaning up..." Write-Host "Cleaning up..."
Remove-Item -Path "$env:TEMP\AdobeCreativeCloudCleanerTool.exe" -Verbose Remove-Item -Path "$env:TEMP\AdobeCreativeCloudCleanerTool.exe" -Verbose
} }
} }
}