Re-Redesign of the Install Tab (#3350)

* Initial Remove Expanded View

* more cleanup

* Add word wrapping for Tooltips

* Update tooltip colors in themes and XAML styles

* Rename Properties for consistency

* More Cleanup, and simplification. Also added support for screenreaders

* Remove unused variables and shorten window naming

* Rename Invoke-WPFUIApps to Initialize-WPFUI and update function calls for consistency

* Rename Invoke-WPFUIApps.ps1 to Initialize-WPFUI.ps1

* Add TODO comments for sidebar UI generation in Initialize-WPFUI function

functions/public/Initialize-WPFUI.ps1

@@ -0,0 +1,57 @@
+function Initialize-WPFUI {
+    [OutputType([void])]
+    param(
+        [Parameter(Mandatory)]
+        [string]$TargetGridName
+    )
+
+    switch ($TargetGridName) {
+        "appscategory"{
+            # TODO 
+            # Switch UI generation of the sidebar to this function
+            # $sync.ItemsControl = Initialize-InstallAppArea -TargetElement $TargetGridName
+            # ...
+
+            # Create and configure a popup for displaying selected apps
+            $selectedAppsPopup = New-Object Windows.Controls.Primitives.Popup
+            $selectedAppsPopup.IsOpen = $false
+            $selectedAppsPopup.PlacementTarget = $sync.WPFselectedAppsButton
+            $selectedAppsPopup.Placement = [System.Windows.Controls.Primitives.PlacementMode]::Bottom
+            $selectedAppsPopup.AllowsTransparency = $true
+
+            # Style the popup with a border and background
+            $selectedAppsBorder = New-Object Windows.Controls.Border
+            $selectedAppsBorder.SetResourceReference([Windows.Controls.Control]::BackgroundProperty, "MainBackgroundColor")
+            $selectedAppsBorder.SetResourceReference([Windows.Controls.Control]::BorderBrushProperty, "MainForegroundColor")
+            $selectedAppsBorder.SetResourceReference([Windows.Controls.Control]::BorderThicknessProperty, "ButtonBorderThickness")
+            $selectedAppsBorder.Width = 200
+            $selectedAppsBorder.Padding = 5
+            $selectedAppsPopup.Child = $selectedAppsBorder
+            $sync.selectedAppsPopup = $selectedAppsPopup
+
+            # Add a stack panel inside the popup's border to organize its child elements
+            $sync.selectedAppsstackPanel = New-Object Windows.Controls.StackPanel
+            $selectedAppsBorder.Child = $sync.selectedAppsstackPanel
+
+            # Close selectedAppsPopup when mouse leaves both button and selectedAppsPopup
+            $sync.WPFselectedAppsButton.Add_MouseLeave({
+                if (-not $sync.selectedAppsPopup.IsMouseOver) {
+                    $sync.selectedAppsPopup.IsOpen = $false
+                }
+            })
+            $selectedAppsPopup.Add_MouseLeave({
+                if (-not $sync.WPFselectedAppsButton.IsMouseOver) {
+                    $sync.selectedAppsPopup.IsOpen = $false
+                }
+            })
+        }
+        "appspanel" {
+            $sync.ItemsControl = Initialize-InstallAppArea -TargetElement $TargetGridName
+            Initialize-InstallCategoryAppList -TargetElement $sync.ItemsControl -Apps $sync.configs.applicationsHashtable
+        }
+        default {
+            Write-Output "$TargetGridName not yet implemented"
+        }
+    }
+}
+

functions/public/Invoke-WPFButton.ps1

@@ -26,8 +26,7 @@ function Invoke-WPFButton {
         "WPFStandard" {Invoke-WPFPresets "Standard" -checkboxfilterpattern "WPFTweak*"}
         "WPFMinimal" {Invoke-WPFPresets "Minimal" -checkboxfilterpattern "WPFTweak*"}
         "WPFClearTweaksSelection" {Invoke-WPFPresets -imported $true -checkboxfilterpattern "WPFTweak*"}
-        "WPFClearInstallSelection" {Invoke-WPFPresets -imported $true -checkboxfilterpattern "WPFInstall*"; Show-OnlyCheckedApps; $sync.wpfselectedfilter.IsChecked = $false}
-        "WPFSelectedFilter" {Show-OnlyCheckedApps -appKeys $sync.SelectedApps}
+        "WPFClearInstallSelection" {Invoke-WPFPresets -imported $true -checkboxfilterpattern "WPFInstall*"}
         "WPFtweaksbutton" {Invoke-WPFtweaksbutton}
         "WPFOOSUbutton" {Invoke-WPFOOSU}
         "WPFAddUltPerf" {Invoke-WPFUltimatePerformance -State "Enable"}
@@ -62,5 +61,6 @@ function Invoke-WPFButton {
         "WPFWinUtilInstallPSProfile" {Invoke-WinUtilInstallPSProfile}
         "WPFWinUtilUninstallPSProfile" {Invoke-WinUtilUninstallPSProfile}
         "WPFWinUtilSSHServer" {Invoke-WPFSSHServer}
+        "WPFselectedAppsButton" {$sync.selectedAppsPopup.IsOpen = -not $sync.selectedAppsPopup.IsOpen}
     }
 }

functions/public/Invoke-WPFGetInstalled.ps1

@@ -19,15 +19,11 @@ function Invoke-WPFGetInstalled {
         return
     }
     $managerPreference = $sync["ManagerPreference"]
-    $sync.ItemsControl.Dispatcher.Invoke([action] {
-            $sync.ItemsControl.Items | ForEach-Object { $_.Visibility = [Windows.Visibility]::Collapsed }
-            $null = $sync.itemsControl.Items.Add($sync.LoadingLabel)
-        })
-    Invoke-WPFRunspace -ParameterList @(("managerPreference", $managerPreference),("checkbox", $checkbox),("ShowOnlyCheckedApps", ${function:Show-OnlyCheckedApps})) -DebugPreference $DebugPreference -ScriptBlock {
+
+    Invoke-WPFRunspace -ParameterList @(("managerPreference", $managerPreference),("checkbox", $checkbox)) -DebugPreference $DebugPreference -ScriptBlock {
         param (
             [string]$checkbox,
-            [PackageManagers]$managerPreference,
-            [scriptblock]$ShowOnlyCheckedApps
+            [PackageManagers]$managerPreference
         )
         $sync.ProcessRunning = $true
         $sync.form.Dispatcher.Invoke([action] { Set-WinUtilTaskbaritem -state "Indeterminate" })
@@ -49,11 +45,7 @@ function Invoke-WPFGetInstalled {
                 $sync.$checkbox.ischecked = $True
             }
         })
-        $sync.ItemsControl.Dispatcher.Invoke([action] {
-            $ShowOnlyCheckedApps.Invoke($sync.SelectedApps)
-            $sync["WPFSelectedFilter"].IsChecked = $true
-            $sync.ItemsControl.Items.Remove($sync.LoadingLabel)
-        })
+
         Write-Host "Done..."
         $sync.ProcessRunning = $false
         $sync.form.Dispatcher.Invoke([action] { Set-WinUtilTaskbaritem -state "None" })

functions/public/Invoke-WPFInstall.ps1

@@ -34,7 +34,6 @@ function Invoke-WPFInstall {
 
         try {
             $sync.ProcessRunning = $true
-            $errorPackages = @()
             if($packagesWinget.Count -gt 0) {
                 Install-WinUtilWinget
                 Install-WinUtilProgramWinget -Action Install -Programs $packagesWinget

functions/public/Invoke-WPFSelectedAppsUpdate.ps1

@@ -20,7 +20,7 @@ function Invoke-WPFSelectedAppsUpdate {
 
     $selectedAppsButton = $sync.WPFselectedAppsButton
     # Get the actual Name from the selectedAppLabel inside the Checkbox
-    $appKey = $checkbox.Parent.Parent.Tag
+    $appKey = $checkbox.Parent.Tag
     if ($type -eq "Add") {
         $sync.selectedApps.Add($appKey)
         # The List type needs to be specified again, because otherwise Sort-Object will convert the list to a string if there is only a single entry

functions/public/Invoke-WPFUIApps.ps1

@@ -1,22 +0,0 @@
-function Invoke-WPFUIApps {
-    [OutputType([void])]
-    param(
-        [Parameter(Mandatory, Position = 0)]
-        [PSCustomObject[]]$Apps,
-        [Parameter(Mandatory, Position = 1)]
-        [string]$TargetGridName
-    )
-
-    switch ($TargetGridName) {
-        "appspanel" {
-            $dockPanel = Initialize-InstallAppsMainElement -TargetGridName $TargetGridName
-            $null = Initialize-InstallHeader -TargetElement $dockPanel
-            $sync.ItemsControl = Initialize-InstallAppArea -TargetElement $dockPanel
-            Initialize-InstallCategoryAppList -TargetElement $sync.ItemsControl -Apps $Apps
-        }
-        default {
-            Write-Output "$TargetGridName not yet implemented"
-        }
-    }
-}
-

functions/public/Invoke-WPFUIElements.ps1

@@ -93,12 +93,6 @@ function Invoke-WPFUIElements {
         # Store application data in an array under the category
         $organizedData[$entryObject.Panel][$entryObject.Category] += $entryObject
 
-        # Only apply the logic for distributing entries across columns if the targetGridName is "appspanel"
-        if ($targetGridName -eq "appspanel") {
-            $panelcount = 0
-            $entrycount = $configHashtable.Keys.Count + $organizedData["0"].Keys.Count
-        }
-
     }
 
     # Initialize panel count

functions/public/Invoke-WPFtweaksbutton.ps1

@@ -25,7 +25,7 @@ function Invoke-WPFtweaksbutton {
   Write-Debug "Number of tweaks to process: $($Tweaks.Count)"
 
   # The leading "," in the ParameterList is nessecary because we only provide one argument and powershell cannot be convinced that we want a nested loop with only one argument otherwise
-  $tweaksHandle = Invoke-WPFRunspace -ParameterList @(,("tweaks",$tweaks)) -DebugPreference $DebugPreference -ScriptBlock {
+  Invoke-WPFRunspace -ParameterList @(,("tweaks",$tweaks)) -DebugPreference $DebugPreference -ScriptBlock {
     param(
       $tweaks,
       $DebugPreference