refactor: enhance timeline component by improving drag-and-drop functionality and clip selection handling

This commit is contained in:
DevloperAmanSingh
2025-06-27 07:56:18 +05:30
parent 0bdbd7e2b3
commit c32daa4f2e

View File

@ -1,27 +1,37 @@
"use client"; "use client";
import { processMediaFiles } from "@/lib/media-processing"; import { ScrollArea } from "../ui/scroll-area";
import { useMediaStore } from "@/stores/media-store"; import { Button } from "../ui/button";
import { usePlaybackStore } from "@/stores/playback-store";
import { useTimelineStore, type TimelineTrack } from "@/stores/timeline-store";
import { import {
Scissors,
ArrowLeftToLine, ArrowLeftToLine,
ArrowRightToLine, ArrowRightToLine,
Copy,
MoreVertical,
Pause,
Play,
Scissors,
Snowflake,
SplitSquareHorizontal,
Trash2, Trash2,
Snowflake,
Copy,
SplitSquareHorizontal,
Volume2, Volume2,
VolumeX, VolumeX,
Pause,
Play,
} from "lucide-react"; } from "lucide-react";
import { useCallback, useEffect, useRef, useState } from "react"; import {
Tooltip,
TooltipContent,
TooltipTrigger,
TooltipProvider,
} from "../ui/tooltip";
import {
useTimelineStore,
type TimelineTrack,
type TimelineClip as TypeTimelineClip,
} from "@/stores/timeline-store";
import { useMediaStore } from "@/stores/media-store";
import { usePlaybackStore } from "@/stores/playback-store";
import { useDragClip } from "@/hooks/use-drag-clip";
import { processMediaFiles } from "@/lib/media-processing";
import { toast } from "sonner"; import { toast } from "sonner";
import { Button } from "../ui/button"; import { useState, useRef, useEffect, useCallback } from "react";
import { ScrollArea } from "../ui/scroll-area";
import { import {
Select, Select,
SelectContent, SelectContent,
@ -29,15 +39,8 @@ import {
SelectTrigger, SelectTrigger,
SelectValue, SelectValue,
} from "../ui/select"; } from "../ui/select";
import { TimelineClip } from "./timeline-clip";
import { import { ContextMenuState } from "@/types/timeline";
Tooltip,
TooltipContent,
TooltipProvider,
TooltipTrigger,
} from "../ui/tooltip";
import AudioWaveform from "./audio-waveform";
export function Timeline() { export function Timeline() {
// Timeline shows all tracks (video, audio, effects) and their clips. // Timeline shows all tracks (video, audio, effects) and their clips.
@ -55,12 +58,12 @@ export function Timeline() {
clearSelectedClips, clearSelectedClips,
setSelectedClips, setSelectedClips,
updateClipTrim, updateClipTrim,
undo,
redo,
splitClip, splitClip,
splitAndKeepLeft, splitAndKeepLeft,
splitAndKeepRight, splitAndKeepRight,
separateAudio, separateAudio,
undo,
redo,
} = useTimelineStore(); } = useTimelineStore();
const { mediaItems, addMediaItem } = useMediaStore(); const { mediaItems, addMediaItem } = useMediaStore();
const { const {
@ -75,19 +78,14 @@ export function Timeline() {
} = usePlaybackStore(); } = usePlaybackStore();
const [isDragOver, setIsDragOver] = useState(false); const [isDragOver, setIsDragOver] = useState(false);
const [isProcessing, setIsProcessing] = useState(false); const [isProcessing, setIsProcessing] = useState(false);
const [progress, setProgress] = useState(0);
const [zoomLevel, setZoomLevel] = useState(1); const [zoomLevel, setZoomLevel] = useState(1);
const dragCounterRef = useRef(0); const dragCounterRef = useRef(0);
const timelineRef = useRef<HTMLDivElement>(null); const timelineRef = useRef<HTMLDivElement>(null);
const [isInTimeline, setIsInTimeline] = useState(false); const [isInTimeline, setIsInTimeline] = useState(false);
// Unified context menu state // Unified context menu state
const [contextMenu, setContextMenu] = useState<{ const [contextMenu, setContextMenu] = useState<ContextMenuState | null>(null);
type: "track" | "clip";
trackId: string;
clipId?: string;
x: number;
y: number;
} | null>(null);
// Marquee selection state // Marquee selection state
const [marquee, setMarquee] = useState<{ const [marquee, setMarquee] = useState<{
@ -340,8 +338,12 @@ export function Timeline() {
} else if (e.dataTransfer.files?.length > 0) { } else if (e.dataTransfer.files?.length > 0) {
// Handle file drops by creating new tracks // Handle file drops by creating new tracks
setIsProcessing(true); setIsProcessing(true);
setProgress(0);
try { try {
const processedItems = await processMediaFiles(e.dataTransfer.files); const processedItems = await processMediaFiles(
e.dataTransfer.files,
(p) => setProgress(p)
);
for (const processedItem of processedItems) { for (const processedItem of processedItems) {
addMediaItem(processedItem); addMediaItem(processedItem);
const currentMediaItems = useMediaStore.getState().mediaItems; const currentMediaItems = useMediaStore.getState().mediaItems;
@ -369,6 +371,7 @@ export function Timeline() {
toast.error("Failed to process dropped files"); toast.error("Failed to process dropped files");
} finally { } finally {
setIsProcessing(false); setIsProcessing(false);
setProgress(0);
} }
} }
}; };
@ -456,7 +459,6 @@ export function Timeline() {
toast.error("No clips selected"); toast.error("No clips selected");
return; return;
} }
let splitCount = 0; let splitCount = 0;
selectedClips.forEach(({ trackId, clipId }) => { selectedClips.forEach(({ trackId, clipId }) => {
const track = tracks.find((t) => t.id === trackId); const track = tracks.find((t) => t.id === trackId);
@ -472,7 +474,6 @@ export function Timeline() {
} }
} }
}); });
if (splitCount > 0) { if (splitCount > 0) {
toast.success(`Split ${splitCount} clip(s) at playhead`); toast.success(`Split ${splitCount} clip(s) at playhead`);
} else { } else {
@ -527,7 +528,6 @@ export function Timeline() {
}); });
toast.success("Freeze frame added for selected clip(s)"); toast.success("Freeze frame added for selected clip(s)");
}; };
const handleSplitAndKeepLeft = () => { const handleSplitAndKeepLeft = () => {
if (selectedClips.length === 0) { if (selectedClips.length === 0) {
toast.error("No clips selected"); toast.error("No clips selected");
@ -540,8 +540,7 @@ export function Timeline() {
const clip = track?.clips.find((c) => c.id === clipId); const clip = track?.clips.find((c) => c.id === clipId);
if (clip && track) { if (clip && track) {
const effectiveStart = clip.startTime; const effectiveStart = clip.startTime;
const effectiveEnd = const effectiveEnd = clip.startTime + (clip.duration - clip.trimStart - clip.trimEnd);
clip.startTime + (clip.duration - clip.trimStart - clip.trimEnd);
if (currentTime > effectiveStart && currentTime < effectiveEnd) { if (currentTime > effectiveStart && currentTime < effectiveEnd) {
splitAndKeepLeft(trackId, clipId, currentTime); splitAndKeepLeft(trackId, clipId, currentTime);
@ -569,8 +568,7 @@ export function Timeline() {
const clip = track?.clips.find((c) => c.id === clipId); const clip = track?.clips.find((c) => c.id === clipId);
if (clip && track) { if (clip && track) {
const effectiveStart = clip.startTime; const effectiveStart = clip.startTime;
const effectiveEnd = const effectiveEnd = clip.startTime + (clip.duration - clip.trimStart - clip.trimEnd);
clip.startTime + (clip.duration - clip.trimStart - clip.trimEnd);
if (currentTime > effectiveStart && currentTime < effectiveEnd) { if (currentTime > effectiveStart && currentTime < effectiveEnd) {
splitAndKeepRight(trackId, clipId, currentTime); splitAndKeepRight(trackId, clipId, currentTime);
@ -598,12 +596,7 @@ export function Timeline() {
const clip = track?.clips.find((c) => c.id === clipId); const clip = track?.clips.find((c) => c.id === clipId);
const mediaItem = mediaItems.find((item) => item.id === clip?.mediaId); const mediaItem = mediaItems.find((item) => item.id === clip?.mediaId);
if ( if (clip && track && mediaItem?.type === "video" && track.type === "video") {
clip &&
track &&
mediaItem?.type === "video" &&
track.type === "video"
) {
const audioClipId = separateAudio(trackId, clipId); const audioClipId = separateAudio(trackId, clipId);
if (audioClipId) separatedCount++; if (audioClipId) separatedCount++;
} }
@ -615,7 +608,6 @@ export function Timeline() {
toast.error("Select video clips to separate audio"); toast.error("Select video clips to separate audio");
} }
}; };
const handleDeleteSelected = () => { const handleDeleteSelected = () => {
if (selectedClips.length === 0) { if (selectedClips.length === 0) {
toast.error("No clips selected"); toast.error("No clips selected");
@ -722,7 +714,6 @@ export function Timeline() {
<div className="w-px h-6 bg-border mx-1" /> <div className="w-px h-6 bg-border mx-1" />
{/* Clip editing operations */}
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<Button variant="text" size="icon" onClick={handleSplitSelected}> <Button variant="text" size="icon" onClick={handleSplitSelected}>
@ -734,11 +725,7 @@ export function Timeline() {
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<Button <Button variant="text" size="icon" onClick={handleSplitAndKeepLeft}>
variant="text"
size="icon"
onClick={handleSplitAndKeepLeft}
>
<ArrowLeftToLine className="h-4 w-4" /> <ArrowLeftToLine className="h-4 w-4" />
</Button> </Button>
</TooltipTrigger> </TooltipTrigger>
@ -747,11 +734,7 @@ export function Timeline() {
<Tooltip> <Tooltip>
<TooltipTrigger asChild> <TooltipTrigger asChild>
<Button <Button variant="text" size="icon" onClick={handleSplitAndKeepRight}>
variant="text"
size="icon"
onClick={handleSplitAndKeepRight}
>
<ArrowRightToLine className="h-4 w-4" /> <ArrowRightToLine className="h-4 w-4" />
</Button> </Button>
</TooltipTrigger> </TooltipTrigger>
@ -1021,6 +1004,16 @@ export function Timeline() {
y: e.clientY, y: e.clientY,
}); });
}} }}
onClick={(e) => {
// If clicking empty area (not on a clip), deselect all clips
if (
!(e.target as HTMLElement).closest(".timeline-clip")
) {
const { clearSelectedClips } =
useTimelineStore.getState();
clearSelectedClips();
}
}}
> >
<TimelineTrackContent <TimelineTrackContent
track={track} track={track}
@ -1045,14 +1038,12 @@ export function Timeline() {
</> </>
)} )}
{isDragOver && ( {isDragOver && (
<div <div className="absolute inset-0 z-20 flex items-center justify-center pointer-events-none backdrop-blur-lg">
className="absolute left-0 right-0 border-2 border-dashed border-accent flex items-center justify-center text-muted-foreground" <div>
style={{ {isProcessing
top: `${tracks.length * 60}px`, ? `Processing ${progress}%`
height: "60px", : "Drop media here to add to timeline"}
}} </div>
>
<div>Drop media here to add a new track</div>
</div> </div>
)} )}
</div> </div>
@ -1081,22 +1072,17 @@ export function Timeline() {
setContextMenu(null); setContextMenu(null);
}} }}
> >
{(() => { {contextMenu.trackId ? (
const track = tracks.find( <div className="flex items-center w-full px-3 py-2 hover:bg-accent hover:text-accent-foreground transition-colors text-left">
(t) => t.id === contextMenu.trackId <Volume2 className="h-4 w-4 mr-2" />
); Unmute Track
return track?.muted ? ( </div>
<> ) : (
<Volume2 className="h-4 w-4 mr-2" /> <div className="flex items-center w-full px-3 py-2 hover:bg-accent hover:text-accent-foreground transition-colors text-left">
Unmute Track <VolumeX className="h-4 w-4 mr-2" />
</> Mute Track
) : ( </div>
<> )}
<VolumeX className="h-4 w-4 mr-2" />
Mute Track
</>
);
})()}
</button> </button>
<div className="h-px bg-border mx-1 my-1" /> <div className="h-px bg-border mx-1 my-1" />
<button <button
@ -1226,134 +1212,191 @@ function TimelineTrackContent({
}: { }: {
track: TimelineTrack; track: TimelineTrack;
zoomLevel: number; zoomLevel: number;
setContextMenu: ( setContextMenu: (menu: ContextMenuState | null) => void;
menu: { contextMenu: ContextMenuState | null;
type: "track" | "clip";
trackId: string;
clipId?: string;
x: number;
y: number;
} | null
) => void;
contextMenu: {
type: "track" | "clip";
trackId: string;
clipId?: string;
x: number;
y: number;
} | null;
}) { }) {
const { mediaItems } = useMediaStore(); const { mediaItems } = useMediaStore();
const { const {
tracks, tracks,
moveClipToTrack, moveClipToTrack,
updateClipTrim,
updateClipStartTime, updateClipStartTime,
addClipToTrack, addClipToTrack,
removeClipFromTrack,
toggleTrackMute,
selectedClips, selectedClips,
selectClip, selectClip,
deselectClip, deselectClip,
dragState,
startDrag: startDragAction,
updateDragTime,
endDrag: endDragAction,
} = useTimelineStore(); } = useTimelineStore();
const { currentTime } = usePlaybackStore();
const timelineRef = useRef<HTMLDivElement>(null);
const [isDropping, setIsDropping] = useState(false); const [isDropping, setIsDropping] = useState(false);
const [dropPosition, setDropPosition] = useState<number | null>(null); const [dropPosition, setDropPosition] = useState<number | null>(null);
const [isDraggedOver, setIsDraggedOver] = useState(false);
const [wouldOverlap, setWouldOverlap] = useState(false); const [wouldOverlap, setWouldOverlap] = useState(false);
const [resizing, setResizing] = useState<{
clipId: string;
side: "left" | "right";
startX: number;
initialTrimStart: number;
initialTrimEnd: number;
} | null>(null);
const dragCounterRef = useRef(0); const dragCounterRef = useRef(0);
const [clipMenuOpen, setClipMenuOpen] = useState<string | null>(null); const [mouseDownLocation, setMouseDownLocation] = useState<{
x: number;
y: number;
} | null>(null);
// Handle clip deletion // Set up mouse event listeners for drag
const handleDeleteClip = (clipId: string) => { useEffect(() => {
removeClipFromTrack(track.id, clipId); if (!dragState.isDragging) return;
const handleMouseMove = (e: MouseEvent) => {
if (!timelineRef.current) return;
const timelineRect = timelineRef.current.getBoundingClientRect();
const mouseX = e.clientX - timelineRect.left;
const mouseTime = Math.max(0, mouseX / (50 * zoomLevel));
const adjustedTime = Math.max(0, mouseTime - dragState.clickOffsetTime);
const snappedTime = Math.round(adjustedTime * 10) / 10;
updateDragTime(snappedTime);
};
const handleMouseUp = () => {
if (!dragState.clipId || !dragState.trackId) return;
const finalTime = dragState.currentTime;
// Check for overlaps and update position
const sourceTrack = tracks.find((t) => t.id === dragState.trackId);
const movingClip = sourceTrack?.clips.find(
(c) => c.id === dragState.clipId
);
if (movingClip) {
const movingClipDuration =
movingClip.duration - movingClip.trimStart - movingClip.trimEnd;
const movingClipEnd = finalTime + movingClipDuration;
const targetTrack = tracks.find((t) => t.id === track.id);
const hasOverlap = targetTrack?.clips.some((existingClip) => {
if (
dragState.trackId === track.id &&
existingClip.id === dragState.clipId
) {
return false;
}
const existingStart = existingClip.startTime;
const existingEnd =
existingClip.startTime +
(existingClip.duration -
existingClip.trimStart -
existingClip.trimEnd);
return finalTime < existingEnd && movingClipEnd > existingStart;
});
if (!hasOverlap) {
if (dragState.trackId === track.id) {
updateClipStartTime(track.id, dragState.clipId, finalTime);
} else {
moveClipToTrack(dragState.trackId, track.id, dragState.clipId);
requestAnimationFrame(() => {
updateClipStartTime(track.id, dragState.clipId!, finalTime);
});
}
}
}
endDragAction();
};
document.addEventListener("mousemove", handleMouseMove);
document.addEventListener("mouseup", handleMouseUp);
return () => {
document.removeEventListener("mousemove", handleMouseMove);
document.removeEventListener("mouseup", handleMouseUp);
};
}, [
dragState.isDragging,
dragState.clickOffsetTime,
dragState.clipId,
dragState.trackId,
dragState.currentTime,
zoomLevel,
tracks,
track.id,
updateDragTime,
updateClipStartTime,
moveClipToTrack,
endDragAction,
]);
const handleClipMouseDown = (e: React.MouseEvent, clip: TypeTimelineClip) => {
setMouseDownLocation({ x: e.clientX, y: e.clientY });
// Handle multi-selection only in mousedown
if (e.metaKey || e.ctrlKey || e.shiftKey) {
selectClip(track.id, clip.id, true);
}
// Calculate the offset from the left edge of the clip to where the user clicked
const clipElement = e.currentTarget as HTMLElement;
const clipRect = clipElement.getBoundingClientRect();
const clickOffsetX = e.clientX - clipRect.left;
const clickOffsetTime = clickOffsetX / (50 * zoomLevel);
startDragAction(
clip.id,
track.id,
e.clientX,
clip.startTime,
clickOffsetTime
);
}; };
const handleResizeStart = ( const handleClipClick = (e: React.MouseEvent, clip: TypeTimelineClip) => {
e: React.MouseEvent,
clipId: string,
side: "left" | "right"
) => {
e.stopPropagation(); e.stopPropagation();
e.preventDefault();
const clip = track.clips.find((c) => c.id === clipId); // Check if mouse moved significantly
if (!clip) return; if (mouseDownLocation) {
const deltaX = Math.abs(e.clientX - mouseDownLocation.x);
const deltaY = Math.abs(e.clientY - mouseDownLocation.y);
// If it moved more than a few pixels, consider it a drag and not a click.
if (deltaX > 5 || deltaY > 5) {
setMouseDownLocation(null); // Reset for next interaction
return;
}
}
setResizing({ // Close context menu if it's open
clipId, if (contextMenu) {
side, setContextMenu(null);
startX: e.clientX, return; // Don't handle selection when closing context menu
initialTrimStart: clip.trimStart, }
initialTrimEnd: clip.trimEnd,
});
};
const updateTrimFromMouseMove = (e: { clientX: number }) => { // Skip selection logic for multi-selection (handled in mousedown)
if (!resizing) return; if (e.metaKey || e.ctrlKey || e.shiftKey) {
return;
}
const clip = track.clips.find((c) => c.id === resizing.clipId); // Handle single selection/deselection
if (!clip) return; const isSelected = selectedClips.some(
(c) => c.trackId === track.id && c.clipId === clip.id
);
const deltaX = e.clientX - resizing.startX; if (isSelected) {
const deltaTime = deltaX / (50 * zoomLevel); // If clip is selected, deselect it
deselectClip(track.id, clip.id);
if (resizing.side === "left") {
const newTrimStart = Math.max(
0,
Math.min(
clip.duration - clip.trimEnd - 0.1,
resizing.initialTrimStart + deltaTime
)
);
updateClipTrim(track.id, clip.id, newTrimStart, clip.trimEnd);
} else { } else {
const newTrimEnd = Math.max( // If clip is not selected, select it (replacing other selections)
0, selectClip(track.id, clip.id, false);
Math.min(
clip.duration - clip.trimStart - 0.1,
resizing.initialTrimEnd - deltaTime
)
);
updateClipTrim(track.id, clip.id, clip.trimStart, newTrimEnd);
} }
}; };
const handleResizeMove = (e: React.MouseEvent) => { const handleClipContextMenu = (e: React.MouseEvent, clipId: string) => {
updateTrimFromMouseMove(e); e.preventDefault();
}; e.stopPropagation();
setContextMenu({
const handleResizeEnd = () => { type: "clip",
setResizing(null); trackId: track.id,
}; clipId: clipId,
x: e.clientX,
const handleClipDragStart = (e: React.DragEvent, clip: any) => { y: e.clientY,
const dragData = { clipId: clip.id, trackId: track.id, name: clip.name }; });
e.dataTransfer.setData(
"application/x-timeline-clip",
JSON.stringify(dragData)
);
e.dataTransfer.effectAllowed = "move";
// Add visual feedback to the dragged element
const target = e.currentTarget.parentElement as HTMLElement;
target.style.opacity = "0.5";
target.style.transform = "scale(0.95)";
};
const handleClipDragEnd = (e: React.DragEvent) => {
// Reset visual feedback
const target = e.currentTarget.parentElement as HTMLElement;
target.style.opacity = "";
target.style.transform = "";
}; };
const handleTrackDragOver = (e: React.DragEvent) => { const handleTrackDragOver = (e: React.DragEvent) => {
@ -1473,14 +1516,12 @@ function TimelineTrackContent({
if (wouldOverlap) { if (wouldOverlap) {
e.dataTransfer.dropEffect = "none"; e.dataTransfer.dropEffect = "none";
setIsDraggedOver(true);
setWouldOverlap(true); setWouldOverlap(true);
setDropPosition(Math.round(dropTime * 10) / 10); setDropPosition(Math.round(dropTime * 10) / 10);
return; return;
} }
e.dataTransfer.dropEffect = hasTimelineClip ? "move" : "copy"; e.dataTransfer.dropEffect = hasTimelineClip ? "move" : "copy";
setIsDraggedOver(true);
setWouldOverlap(false); setWouldOverlap(false);
setDropPosition(Math.round(dropTime * 10) / 10); setDropPosition(Math.round(dropTime * 10) / 10);
}; };
@ -1499,7 +1540,6 @@ function TimelineTrackContent({
dragCounterRef.current++; dragCounterRef.current++;
setIsDropping(true); setIsDropping(true);
setIsDraggedOver(true);
}; };
const handleTrackDragLeave = (e: React.DragEvent) => { const handleTrackDragLeave = (e: React.DragEvent) => {
@ -1518,7 +1558,6 @@ function TimelineTrackContent({
if (dragCounterRef.current === 0) { if (dragCounterRef.current === 0) {
setIsDropping(false); setIsDropping(false);
setIsDraggedOver(false);
setWouldOverlap(false); setWouldOverlap(false);
setDropPosition(null); setDropPosition(null);
} }
@ -1531,7 +1570,6 @@ function TimelineTrackContent({
// Reset all drag states // Reset all drag states
dragCounterRef.current = 0; dragCounterRef.current = 0;
setIsDropping(false); setIsDropping(false);
setIsDraggedOver(false);
setWouldOverlap(false); setWouldOverlap(false);
const currentDropPosition = dropPosition; const currentDropPosition = dropPosition;
setDropPosition(null); setDropPosition(null);
@ -1563,23 +1601,36 @@ function TimelineTrackContent({
); );
if (!timelineClipData) return; if (!timelineClipData) return;
const { clipId, trackId: fromTrackId } = JSON.parse(timelineClipData); const {
clipId,
trackId: fromTrackId,
clickOffsetTime = 0,
} = JSON.parse(timelineClipData);
// Find the clip being moved // Find the clip being moved
const sourceTrack = tracks.find( const sourceTrack = tracks.find(
(t: TimelineTrack) => t.id === fromTrackId (t: TimelineTrack) => t.id === fromTrackId
); );
const movingClip = sourceTrack?.clips.find((c: any) => c.id === clipId); const movingClip = sourceTrack?.clips.find(
(c: TypeTimelineClip) => c.id === clipId
);
if (!movingClip) { if (!movingClip) {
toast.error("Clip not found"); toast.error("Clip not found");
return; return;
} }
// Adjust position based on where user clicked on the clip
const adjustedStartTime = snappedTime - clickOffsetTime;
const finalStartTime = Math.max(
0,
Math.round(adjustedStartTime * 10) / 10
);
// Check for overlaps with existing clips (excluding the moving clip itself) // Check for overlaps with existing clips (excluding the moving clip itself)
const movingClipDuration = const movingClipDuration =
movingClip.duration - movingClip.trimStart - movingClip.trimEnd; movingClip.duration - movingClip.trimStart - movingClip.trimEnd;
const movingClipEnd = snappedTime + movingClipDuration; const movingClipEnd = finalStartTime + movingClipDuration;
const hasOverlap = track.clips.some((existingClip) => { const hasOverlap = track.clips.some((existingClip) => {
// Skip the clip being moved if it's on the same track // Skip the clip being moved if it's on the same track
@ -1594,7 +1645,7 @@ function TimelineTrackContent({
existingClip.trimEnd); existingClip.trimEnd);
// Check if clips overlap // Check if clips overlap
return snappedTime < existingEnd && movingClipEnd > existingStart; return finalStartTime < existingEnd && movingClipEnd > existingStart;
}); });
if (hasOverlap) { if (hasOverlap) {
@ -1606,12 +1657,12 @@ function TimelineTrackContent({
if (fromTrackId === track.id) { if (fromTrackId === track.id) {
// Moving within same track // Moving within same track
updateClipStartTime(track.id, clipId, snappedTime); updateClipStartTime(track.id, clipId, finalStartTime);
} else { } else {
// Moving to different track // Moving to different track
moveClipToTrack(fromTrackId, track.id, clipId); moveClipToTrack(fromTrackId, track.id, clipId);
requestAnimationFrame(() => { requestAnimationFrame(() => {
updateClipStartTime(track.id, clipId, snappedTime); updateClipStartTime(track.id, clipId, finalStartTime);
}); });
} }
} else if (hasMediaItem) { } else if (hasMediaItem) {
@ -1679,114 +1730,9 @@ function TimelineTrackContent({
} }
}; };
const getTrackColor = (type: string) => {
switch (type) {
case "video":
return "bg-blue-500/20 border-blue-500/30";
case "audio":
return "bg-green-500/20 border-green-500/30";
case "effects":
return "bg-purple-500/20 border-purple-500/30";
default:
return "bg-gray-500/20 border-gray-500/30";
}
};
const renderClipContent = (clip: any) => {
const mediaItem = mediaItems.find((item) => item.id === clip.mediaId);
if (!mediaItem) {
return (
<span className="text-xs text-foreground/80 truncate">{clip.name}</span>
);
}
if (mediaItem.type === "image") {
return (
<div className="w-full h-full flex items-center justify-center">
<img
src={mediaItem.url}
alt={mediaItem.name}
className="w-full h-full object-cover"
/>
</div>
);
}
if (mediaItem.type === "video" && mediaItem.thumbnailUrl) {
return (
<div className="w-full h-full flex items-center gap-2">
<div className="w-8 h-8 flex-shrink-0">
<img
src={mediaItem.thumbnailUrl}
alt={mediaItem.name}
className="w-full h-full object-cover rounded-sm"
/>
</div>
<span className="text-xs text-foreground/80 truncate flex-1">
{clip.name}
</span>
</div>
);
}
if (mediaItem.type === "audio") {
return (
<div className="w-full h-full flex items-center gap-2">
<div className="flex-1 min-w-0">
<AudioWaveform
audioUrl={mediaItem.url}
height={24}
className="w-full"
/>
</div>
</div>
);
}
// Fallback for videos without thumbnails
return (
<span className="text-xs text-foreground/80 truncate">{clip.name}</span>
);
};
const handleSplitClip = (clip: any) => {
// Use current playback time as split point
const splitTime = currentTime;
// Only split if splitTime is within the clip's effective range
const effectiveStart = clip.startTime;
const effectiveEnd =
clip.startTime + (clip.duration - clip.trimStart - clip.trimEnd);
if (splitTime <= effectiveStart || splitTime >= effectiveEnd) return;
const firstDuration = splitTime - effectiveStart;
const secondDuration = effectiveEnd - splitTime;
// First part: adjust original clip
updateClipTrim(
track.id,
clip.id,
clip.trimStart,
clip.trimEnd + secondDuration
);
// Second part: add new clip after split
addClipToTrack(track.id, {
mediaId: clip.mediaId,
name: clip.name + " (cut)",
duration: clip.duration,
startTime: splitTime,
trimStart: clip.trimStart + firstDuration,
trimEnd: clip.trimEnd,
});
};
return ( return (
<div <div
className={`w-full h-full transition-all duration-150 ease-out ${ className="w-full h-full hover:bg-muted/20"
isDraggedOver
? wouldOverlap
? "bg-red-500/15 border-2 border-dashed border-red-400 shadow-lg"
: "bg-blue-500/15 border-2 border-dashed border-blue-400 shadow-lg"
: "hover:bg-muted/20"
}`}
onContextMenu={(e) => { onContextMenu={(e) => {
e.preventDefault(); e.preventDefault();
// Only show track menu if we didn't click on a clip // Only show track menu if we didn't click on a clip
@ -1799,15 +1745,22 @@ function TimelineTrackContent({
}); });
} }
}} }}
onClick={(e) => {
// If clicking empty area (not on a clip), deselect all clips
if (!(e.target as HTMLElement).closest(".timeline-clip")) {
const { clearSelectedClips } = useTimelineStore.getState();
clearSelectedClips();
}
}}
onDragOver={handleTrackDragOver} onDragOver={handleTrackDragOver}
onDragEnter={handleTrackDragEnter} onDragEnter={handleTrackDragEnter}
onDragLeave={handleTrackDragLeave} onDragLeave={handleTrackDragLeave}
onDrop={handleTrackDrop} onDrop={handleTrackDrop}
onMouseMove={handleResizeMove}
onMouseUp={handleResizeEnd}
onMouseLeave={handleResizeEnd}
> >
<div className="h-full relative track-clips-container min-w-full"> <div
ref={timelineRef}
className="h-full relative track-clips-container min-w-full"
>
{track.clips.length === 0 ? ( {track.clips.length === 0 ? (
<div <div
className={`h-full w-full rounded-sm border-2 border-dashed flex items-center justify-center text-xs text-muted-foreground transition-colors ${ className={`h-full w-full rounded-sm border-2 border-dashed flex items-center justify-center text-xs text-muted-foreground transition-colors ${
@ -1827,134 +1780,23 @@ function TimelineTrackContent({
) : ( ) : (
<> <>
{track.clips.map((clip) => { {track.clips.map((clip) => {
const effectiveDuration =
clip.duration - clip.trimStart - clip.trimEnd;
const clipWidth = Math.max(
80,
effectiveDuration * 50 * zoomLevel
);
const clipLeft = clip.startTime * 50 * zoomLevel;
const isSelected = selectedClips.some( const isSelected = selectedClips.some(
(c) => c.trackId === track.id && c.clipId === clip.id (c) => c.trackId === track.id && c.clipId === clip.id
); );
return ( return (
<div <TimelineClip
key={clip.id} key={clip.id}
className={`timeline-clip absolute h-full border transition-all-200 ${getTrackColor(track.type)} flex items-center py-3 min-w-[80px] overflow-hidden group hover:shadow-lg ${isSelected ? "ring-2 ring-blue-500 z-10" : ""}`} clip={clip}
style={{ width: `${clipWidth}px`, left: `${clipLeft}px` }} track={track}
onClick={(e) => { zoomLevel={zoomLevel}
e.stopPropagation(); isSelected={isSelected}
onContextMenu={handleClipContextMenu}
// Close context menu if it's open onClipMouseDown={handleClipMouseDown}
if (contextMenu) { onClipClick={handleClipClick}
setContextMenu(null); />
return; // Don't handle selection when closing context menu
}
const isSelected = selectedClips.some(
(c) => c.trackId === track.id && c.clipId === clip.id
);
if (e.metaKey || e.ctrlKey || e.shiftKey) {
// Multi-selection mode: toggle the clip
selectClip(track.id, clip.id, true);
} else if (isSelected) {
// If clip is already selected, deselect it
deselectClip(track.id, clip.id);
} else {
// If clip is not selected, select it (replacing other selections)
selectClip(track.id, clip.id, false);
}
}}
tabIndex={0}
onContextMenu={(e) => {
e.preventDefault();
e.stopPropagation();
setContextMenu({
type: "clip",
trackId: track.id,
clipId: clip.id,
x: e.clientX,
y: e.clientY,
});
}}
>
{/* Left trim handle */}
<div
className="absolute left-0 top-0 bottom-0 w-2 cursor-w-resize opacity-0 group-hover:opacity-100 transition-opacity bg-blue-500/50 hover:bg-blue-500"
onMouseDown={(e) => handleResizeStart(e, clip.id, "left")}
/>
{/* Clip content */}
<div
className="flex-1 cursor-grab active:cursor-grabbing relative"
draggable={true}
onDragStart={(e) => handleClipDragStart(e, clip)}
onDragEnd={handleClipDragEnd}
>
{renderClipContent(clip)}
{/* Clip options menu */}
<div className="absolute top-1 right-1 z-10">
<Button
variant="text"
size="icon"
className="opacity-0 group-hover:opacity-100 transition-opacity"
onClick={() => setClipMenuOpen(clip.id)}
>
<MoreVertical className="h-4 w-4" />
</Button>
{clipMenuOpen === clip.id && (
<div className="absolute right-0 mt-2 w-32 bg-white text-black border rounded shadow z-50">
<button
className="flex items-center w-full px-3 py-2 text-sm hover:bg-muted/30"
onClick={() => {
handleSplitClip(clip);
setClipMenuOpen(null);
}}
>
<Scissors className="h-4 w-4 mr-2" /> Split
</button>
<button
className="flex items-center w-full px-3 py-2 text-sm text-red-600 hover:bg-red-50"
onClick={() => handleDeleteClip(clip.id)}
>
<Trash2 className="h-4 w-4 mr-2" /> Delete
</button>
</div>
)}
</div>
</div>
{/* Right trim handle */}
<div
className="absolute right-0 top-0 bottom-0 w-2 cursor-e-resize opacity-0 group-hover:opacity-100 transition-opacity bg-blue-500/50 hover:bg-blue-500"
onMouseDown={(e) => handleResizeStart(e, clip.id, "right")}
/>
</div>
); );
})} })}
{/* Drop position indicator */}
{isDraggedOver && dropPosition !== null && (
<div
className={`absolute top-0 bottom-0 w-1 pointer-events-none z-30 transition-all duration-75 ease-out ${wouldOverlap ? "bg-red-500" : "bg-blue-500"}`}
style={{
left: `${dropPosition * 50 * zoomLevel}px`,
transform: "translateX(-50%)",
}}
>
<div
className={`absolute -top-2 left-1/2 transform -translate-x-1/2 w-3 h-3 rounded-full border-2 border-white shadow-md ${wouldOverlap ? "bg-red-500" : "bg-blue-500"}`}
/>
<div
className={`absolute -bottom-2 left-1/2 transform -translate-x-1/2 w-3 h-3 rounded-full border-2 border-white shadow-md ${wouldOverlap ? "bg-red-500" : "bg-blue-500"}`}
/>
<div
className={`absolute top-1/2 left-1/2 transform -translate-x-1/2 -translate-y-1/2 text-xs text-white px-1 py-0.5 rounded whitespace-nowrap ${wouldOverlap ? "bg-red-500" : "bg-blue-500"}`}
>
{wouldOverlap ? "⚠️" : ""}
{dropPosition.toFixed(1)}s
</div>
</div>
)}
</> </>
)} )}
</div> </div>